Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework mc idp ldap accesskey list to use new API endpoint #4946

Merged
merged 13 commits into from
Jul 31, 2024
Merged

Rework mc idp ldap accesskey list to use new API endpoint #4946

merged 13 commits into from
Jul 31, 2024

Conversation

taran-p
Copy link
Contributor

@taran-p taran-p commented May 29, 2024 •
edited
Loading

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Updates mc idp ldap accesskey list to use the endpoint introduced in minio/minio#19835
Adds --self and --all flags to allow explicitly request listing access keys for the authenticated user or for all users

Motivation and Context

See minio/minio#19835

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@taran-p taran-p force-pushed the accesskey-list-change branch from 44f208d to 43a9388 Compare May 30, 2024 00:00
@taran-p taran-p mentioned this pull request Jun 8, 2024
Merged
8 tasks
@taran-p taran-p marked this pull request as ready for review June 10, 2024 16:29
harshavardhana
harshavardhana requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you show how the terminal UI looks like?

@taran-p
Copy link
Contributor Author

taran-p commented Jun 25, 2024

image
@harshavardhana

@taran-p taran-p requested a review from harshavardhana July 1, 2024 19:19
@taran-p taran-p force-pushed the accesskey-list-change branch from daa0d2d to 7b5ef66 Compare July 30, 2024 00:13
@harshavardhana
Copy link
Member

image @harshavardhana

This UI looks a bit mouthful; changing this and simplifying it.

@harshavardhana harshavardhana merged commit f0d2ad4 into minio:master Jul 31, 2024
6 checks passed
@taran-p taran-p deleted the accesskey-list-change branch July 31, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@donatello donatello donatello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taran-p @harshavardhana @donatello