Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Hex keys #4962

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Conversation

zveinn
Copy link
Contributor

@zveinn zveinn commented Jun 12, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Due to the nature of S3 APIs and the way we declare encryption keys, we can not support encryption keys with the symbol = in them. This makes support for base64 encoding, which includes padding, impossible.

To provide an additional option to the RawBase64Encoding option, this PR adds support for Hex Encoding.

Motivation and Context

Most tools (openssl for example) generate base64 encoded keys with padding, so when they are used in scripts along with mc, they tend to fail. An alternative is to offer support for Hex encoding.

How to test this PR?

The functional test suite includes two tests for hex support.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cmd/encryption-methods.go Outdated Show resolved Hide resolved
cmd/encryption-methods.go Outdated Show resolved Hide resolved
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana requested a review from vadmeste June 17, 2024 17:24
@harshavardhana harshavardhana merged commit adaf70c into minio:master Jun 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants