Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support 'mc put --if-not-exists' #4963

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

harshavardhana
Copy link
Member

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

fix: support 'mc put --if-not-exists'

Also allow 'mc get --version-id'

Motivation and Context

Just nice to have flags that have helped me
to test things locally.

How to test this PR?

As mentioned in the PR

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@harshavardhana
Copy link
Member Author

if-not-exists flag is currently hidden, until we decide to take full inputs like --if-none-match

@jiuker
Copy link
Contributor

jiuker commented Jun 18, 2024

Please fix the lint or add //nolint at that line.

Copy link
Contributor

@zveinn zveinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just remove the unused var.

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(yeah, or use it if it is supposed to be used)

@harshavardhana harshavardhana force-pushed the version-id branch 2 times, most recently from 0935282 to aacbd02 Compare June 18, 2024 16:47
Also allow 'mc get --version-id'
@harshavardhana harshavardhana merged commit a289dae into minio:master Jun 18, 2024
7 checks passed
@harshavardhana harshavardhana deleted the version-id branch June 18, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants