-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LGA-2590 - Skip financial assessment for under eighteens #907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment.
499b830
to
18e89e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
18e89e9
to
19bd2ee
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What does this pull request do?
Skip financial assessment for under eighteens
Any other changes that would benefit highlighting?
There is a problem in the pipelines where bower fails. As this happens before we build, I have added workaround
"strict-ssl": false,
This should NOT be merged in. This is being used to enable end to end testing by getting the build info.We need to create a ticket and decide how to handle the bower errors as this will block us from merging in the future.
Some resources:
Checklist