Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGA-2590 - Skip financial assessment for under eighteens #907

Merged
merged 5 commits into from
Aug 3, 2023

Conversation

said-moj
Copy link
Contributor

@said-moj said-moj commented Jul 20, 2023

What does this pull request do?

Skip financial assessment for under eighteens

Any other changes that would benefit highlighting?

There is a problem in the pipelines where bower fails. As this happens before we build, I have added workaround "strict-ssl": false, This should NOT be merged in. This is being used to enable end to end testing by getting the build info.

We need to create a ticket and decide how to handle the bower errors as this will block us from merging in the future.

Some resources:

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@said-moj said-moj requested a review from a team as a code owner July 20, 2023 14:08
@jogilder jogilder changed the title WIP - LGA-2590 - Skip financial assessment for under eighteens LGA-2590 - Skip financial assessment for under eighteens Aug 1, 2023
Copy link
Contributor

@psweeting1 psweeting1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment.

.bowerrc Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@said-moj said-moj force-pushed the feature/LGA-2590-under-18 branch from 499b830 to 18e89e9 Compare August 2, 2023 08:32
Copy link
Contributor

@jogilder jogilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@psweeting1 psweeting1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@said-moj said-moj force-pushed the feature/LGA-2590-under-18 branch from 18e89e9 to 19bd2ee Compare August 2, 2023 09:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@said-moj said-moj merged commit 211b697 into master Aug 3, 2023
@said-moj said-moj deleted the feature/LGA-2590-under-18 branch August 3, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants