Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create LICENSE.md #365

Merged

Conversation

jeremychinquistdrunomicscom
Copy link
Contributor

Our project requires that the MIT license text be added to the repository. I copied it from the https://spdx.org/licenses/MIT.html#licenseText

Our project requires that the MIT license text be added to the repository. I copied it from the https://spdx.org/licenses/MIT.html#licenseText
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (affb7ea) to head (7274c22).
Report is 15 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #365      +/-   ##
============================================
- Coverage     90.62%   90.19%   -0.44%     
- Complexity      150      168      +18     
============================================
  Files             1        1              
  Lines           448      469      +21     
============================================
+ Hits            406      423      +17     
- Misses           42       46       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aik099
Copy link
Member

aik099 commented May 11, 2023

Can you copy/paste https://github.com/minkphp/driver-testsuite/blob/master/LICENSE file into this repo and update names/years in it? Then it would be more consistent.

@jeremychinquistdrunomicscom
Copy link
Contributor Author

@aik099
I did that but made one exception. I left "MIT License" at the top because it is an indication again of the license and this is used elsewhere.
Should Konstantin also be added, or simply Pete?
Please merge if this is enough.

@aik099
Copy link
Member

aik099 commented Feb 28, 2024

I did that but made one exception. I left "MIT License" at the top because it is an indication again of the license and this is used elsewhere.

I've removed it just because other driver repos don't have this heading and GitHub is detecting license type already (either by it's text or MIT word in the composer.json.

Should Konstantin also be added, or simply Pete?

I'm not sure. I've left it as is.

@aik099
Copy link
Member

aik099 commented Feb 28, 2024

@jeremychinquistdrunomicscom , merging. Thank you.

@aik099 aik099 merged commit a637df5 into minkphp:master Feb 28, 2024
10 of 11 checks passed
@jeremychinquistdrunomicscom
Copy link
Contributor Author

Wonderful, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants