Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes file upload test on Selenium 3 #385

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

aik099
Copy link
Member

@aik099 aik099 commented Feb 25, 2024

Fixes this error from the #383:

2) Behat\Mink\Tests\Driver\Js\ChangeEventTest::testSetValueChangeEvent with data set "file" ('the-file', '/home/runner/work/MinkSeleniu...e1.txt', '/home/runner/work/MinkSeleniu...e2.txt')
WebDriver\Exception\InvalidArgument: File not found: /home/runner/work/MinkSelenium2Driver/MinkSelenium2Driver/vendor/mink/driver-testsuite/web-fixtures/file1.txt
Build info: version: '3.141.59', revision: 'e82be7d358', time: '2018-11-14T08:25:53'
System info: host: 'fv-az697-197', ip: '10.1.0.44', os.name: 'Linux', os.arch: 'amd64', os.version: '5.15.0-1056-azure', java.version: '1.8.0_292'
Driver info: driver.version: unknown

Inspired by the @uuf6429 work on the https://github.com/minkphp/webdriver-classic-driver project.

@aik099 aik099 mentioned this pull request Feb 25, 2024
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.42%. Comparing base (4ca4083) to head (d6fb204).
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #385      +/-   ##
============================================
- Coverage     90.19%   87.42%   -2.78%     
  Complexity      168      168              
============================================
  Files             1        1              
  Lines           469      469              
============================================
- Hits            423      410      -13     
- Misses           46       59      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@uuf6429 uuf6429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind this might conflict with #383. Looks good otherwise.

@aik099
Copy link
Member Author

aik099 commented Feb 26, 2024

Keep in mind this might conflict with #383. Looks good otherwise.

Thank you for the warning. We will see if GitHub is clever enough to perform interactive conflict resolution upon merge.

@aik099 aik099 requested a review from stof March 16, 2024 19:51
@aik099 aik099 merged commit b1f3c59 into minkphp:master Oct 31, 2024
10 of 11 checks passed
@aik099 aik099 deleted the file-upload-test-selenium3-fix branch October 31, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants