Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also test on Chrome for better coverage #409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Also test on Chrome for better coverage #409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,29 @@ jobs:
- run: vendor/bin/phpstan analyze

tests:
name: "Tests (PHP ${{ matrix.php }}, Selenium ${{ matrix.selenium_version }})${{ matrix.with_coverage == true && ' with coverage' || ''}}"
name: "Tests (PHP ${{ matrix.php }}, Sel. ${{ matrix.selenium_version }}), ${{ matrix.browser }}${{ matrix.with_coverage == true && ' with coverage' || ''}}"
runs-on: ubuntu-latest
strategy:
matrix:
selenium_version: [ '2.53.1' ]
browser: [ 'firefox' ]
php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2' ]
with_coverage: [ false ]
include:
- selenium_version: '2.53.1'
browser: 'firefox'
php: '8.3'
with_coverage: true
- selenium_version: '3.141.59'
browser: 'firefox'
php: '8.3'
with_coverage: true
- selenium_version: '2.53.1'
browser: 'chrome'
php: '8.3'
with_coverage: true
- selenium_version: '3.141.59'
browser: 'chrome'
php: '8.3'
with_coverage: true
fail-fast: false
Expand Down Expand Up @@ -82,7 +93,7 @@ jobs:

- name: Start Selenium
run: |
SELENIUM_IMAGE=selenium/standalone-firefox:${{ matrix.selenium_version }} docker compose up --wait
SELENIUM_IMAGE=selenium/standalone-${{ matrix.browser }}:${{ matrix.selenium_version }} docker compose up --wait

- name: Wait for browser & PHP to start
run: |
Expand All @@ -95,7 +106,7 @@ jobs:
SELENIUM_VERSION: ${{ matrix.selenium_version }}
DRIVER_URL: http://localhost:4444/wd/hub
WEB_FIXTURES_HOST: http://host.docker.internal:8002
WEB_FIXTURES_BROWSER: firefox
WEB_FIXTURES_BROWSER: ${{ matrix.browser }}
DRIVER_MACHINE_BASE_PATH: /fixtures/
run: |
vendor/bin/phpunit -v --coverage-clover=coverage.xml --log-junit junit.xml
Expand All @@ -106,7 +117,7 @@ jobs:
SELENIUM_VERSION: ${{ matrix.selenium_version }}
DRIVER_URL: http://localhost:4444/wd/hub
WEB_FIXTURES_HOST: http://host.docker.internal:8002
WEB_FIXTURES_BROWSER: firefox
WEB_FIXTURES_BROWSER: ${{ matrix.browser }}
DRIVER_MACHINE_BASE_PATH: /fixtures/
run: |
vendor/bin/phpunit -v
Expand All @@ -133,6 +144,6 @@ jobs:
if: ${{ failure() }}
uses: actions/upload-artifact@v4
with:
name: logs_php-${{ matrix.php }}_selenium-${{ matrix.selenium_version }}_firefox
name: logs_php-${{ matrix.php }}_selenium-${{ matrix.selenium_version }}_${{ matrix.browser }}
path: |
logs
Loading