Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial stab at supporting systems that do not use 'python' as the Python 3 command #1

Merged
merged 2 commits into from
Jan 2, 2017

Conversation

jesseops
Copy link

yes we are backwards :(

Ubuntu currently still uses python for Python 2, while other distributions (e.g., Arch) use python for Python 3 and python2 for Python 2.

This is a quick fix that uses the platform module to derive information about the system, specifically if it's an Ubuntu system in which case we know how to handle specifying version.

@mirekys
Copy link
Owner

mirekys commented Dec 23, 2016

Hi, I can confirm that even on Arch there is a python3 symlink. I believe that
python3 is nowadays available on most distributions, so there is no need
for the command map as we can just replace python with python3.

@jesseops
Copy link
Author

@mirekys great, I like that way better than the admittedly hacked/ugly bit of code I tossed in to handle the translation. I'll update the pull request.

@mirekys
Copy link
Owner

mirekys commented Jan 2, 2017

Thank you, looks good to me now, merging this. Happy new year :)

@mirekys mirekys merged commit e8d5d88 into mirekys:master Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants