fix corner case in awaits (#5160)

fixes #5159
mishoo · Oct 31, 2021 · a841d45 · a841d45
1 parent eb93d92
commit a841d45
Show file tree

Hide file tree

Showing 2 changed files with 70 additions and 1 deletion.
diff --git a/lib/compress.js b/lib/compress.js
@@ -10334,7 +10334,7 @@ merge(Compressor.prototype, {
                     do {
                         node = parent;
                         parent = compressor.parent(level++);
-                        if (parent instanceof AST_Try && member(node, parent.body)) {
+                        if (parent instanceof AST_Try && (parent.bfinally || parent.bcatch) !== node) {
                             drop = false;
                             break;
                         }

diff --git a/test/compress/awaits.js b/test/compress/awaits.js
@@ -2143,3 +2143,72 @@ issue_5157_promise: {
     expect_stdout: "PASS"
     node_version: ">=8"
 }
+
+issue_5159_1: {
+    options = {
+        awaits: true,
+        side_effects: true,
+    }
+    input: {
+        (async function() {
+            try {
+                throw "foo";
+            } catch (e) {
+                return await "bar";
+            } finally {
+                console.log("baz");
+            }
+        })().catch(console.log).then(console.log);
+        console.log("moo");
+    }
+    expect: {
+        (async function() {
+            try {
+                throw "foo";
+            } catch (e) {
+                return await "bar";
+            } finally {
+                console.log("baz");
+            }
+        })().catch(console.log).then(console.log);
+        console.log("moo");
+    }
+    expect_stdout: [
+        "moo",
+        "baz",
+        "bar",
+    ]
+    node_version: ">=8"
+}
+
+issue_5159_2: {
+    options = {
+        awaits: true,
+        side_effects: true,
+    }
+    input: {
+        (async function() {
+            try {
+                throw "foo";
+            } catch (e) {
+                return await "bar";
+            }
+        })().catch(console.log).then(console.log);
+        console.log("baz");
+    }
+    expect: {
+        (async function() {
+            try {
+                throw "foo";
+            } catch (e) {
+                return "bar";
+            }
+        })().catch(console.log).then(console.log);
+        console.log("baz");
+    }
+    expect_stdout: [
+        "baz",
+        "bar",
+    ]
+    node_version: ">=8"
+}