Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): カスタム絵文字の一括インポートをした時にHTTPプロキシの除外設定が効かないのを修正 #15431

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

samunohito
Copy link
Member

What

DownloadServiceによるファイル取得時に、HTTPプロキシの除外設定に従って適切なhttpAgent/httpsAgentを使用するようにしました。

Why

fix #8766

Additional info (optional)

元issueのSteps to Reproduceどおりに操作して問題の発生を確認

修正後のソースで同じ手順で捜査してインポートが動作するのを確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Feb 8, 2025
@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.1 milestone Feb 11, 2025
Copy link
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 52.38095% with 20 lines in your changes missing coverage. Please review.

Project coverage is 38.65%. Comparing base (ebd06be) to head (af37381).

Files with missing lines Patch % Lines
packages/backend/src/core/HttpRequestService.ts 55.00% 16 Missing and 2 partials ⚠️
packages/backend/src/core/DownloadService.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15431      +/-   ##
===========================================
+ Coverage    37.65%   38.65%   +1.00%     
===========================================
  Files         1607     1607              
  Lines       204854   204887      +33     
  Branches      3717     4018     +301     
===========================================
+ Hits         77135    79205    +2070     
+ Misses      127071   125038    -2033     
+ Partials       648      644       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

import-custom-emojisでプロキシ除外の設定が効かない
2 participants