-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: google analytics #15451
base: develop
Are you sure you want to change the base?
feat: google analytics #15451
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15451 +/- ##
===========================================
+ Coverage 40.86% 44.11% +3.24%
===========================================
Files 1609 1614 +5
Lines 161806 167781 +5975
Branches 3786 4156 +370
===========================================
+ Hits 66119 74013 +7894
+ Misses 95239 93320 -1919
Partials 448 448 ☔ View full report in Codecov by Sentry. |
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -9499,6 +9499,12 @@
"enableTestcaptcha": {
"type": "boolean"
},
+ "googleAnalyticsMeasurementId": {
+ "type": [
+ "string",
+ "null"
+ ]
+ },
"swPublickey": {
"type": [
"string",
@@ -10006,6 +10012,7 @@
"enableTurnstile",
"turnstileSiteKey",
"enableTestcaptcha",
+ "googleAnalyticsMeasurementId",
"swPublickey",
"mascotImageUrl",
"bannerUrl",
@@ -17359,6 +17366,12 @@
"enableTestcaptcha": {
"type": "boolean"
},
+ "googleAnalyticsMeasurementId": {
+ "type": [
+ "string",
+ "null"
+ ]
+ },
"sensitiveMediaDetection": {
"type": "string",
"enum": [
@@ -83252,6 +83265,12 @@
"enableTestcaptcha": {
"type": "boolean"
},
+ "googleAnalyticsMeasurementId": {
+ "type": [
+ "string",
+ "null"
+ ]
+ },
"swPublickey": {
"type": [
"string",
@@ -83445,6 +83464,7 @@
"enableTurnstile",
"turnstileSiteKey",
"enableTestcaptcha",
+ "googleAnalyticsMeasurementId",
"swPublickey",
"mascotImageUrl",
"bannerUrl", |
packages/frontend/src/router/main.ts
Outdated
|
||
analytics.page({ | ||
path: ctx.path, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaceに反応しないのでchangeイベントで取ったほうがいいかも
(ページタイトルの切り替わりがrouterのイベントのタイミングと一致しないのでpageMetadataとタイミングを合わせて送信する必要がありそう) |
issueの流れ見てない人にとってタイトルで把握しづらいと思ったのでタイトル変えました |
最低限の動作はできた |
What
Resolve #15426
Why
Additional info (optional)
Checklist