[Fix] Updated readCiCdExec error response

package.json

@@ -1,6 +1,6 @@
 {
   "name": "helmsman",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "CI/CD from GitHub to your own servers",
   "main": "dist/index.js",
   "scripts": {

src/server/routes/webhook.ts

@@ -4,7 +4,10 @@ const router = Router();
 import 'colors';
 import { exec } from 'child_process';
 import { createHmac, timingSafeEqual } from 'crypto';
-import readCiCdExec from '../../utils/readCiCdExec.js';
+import readCiCdExec, {
+    EXEC_RESPONSE,
+    EXEC_RESPONSE_MAP,
+} from '../../utils/readCiCdExec.js';
 import logger from '../../utils/logger.js';
 
 // import .env
@@ -57,8 +60,8 @@ router.post('/', (req, _, next) => {
     );
     const repositoryBranchStr = `${payloadBody.repository.full_name}: ${payloadBody.ref}`;
     if (ciCdExec) {
-        if (ciCdExec == 'bad_config') {
-            const logMessage = `An error occurred while executing the ${githubEvent} command for "${repositoryBranchStr}" (${githubDelivery}): ${ciCdExec}`;
+        if (typeof ciCdExec != 'string') {
+            const logMessage = `An error occurred while executing the ${githubEvent} command for "${repositoryBranchStr}" (${githubDelivery}): ${EXEC_RESPONSE_MAP[ciCdExec]}`;
             console.error('[server:post]'.red, '/webhook'.gray, logMessage);
             logger(logMessage, 'error');
             return next(500);

src/utils/readCiCdExec.ts

@@ -1,11 +1,19 @@
 import { readFileSync } from 'fs';
 import logger from './logger.js';
 
+enum EXEC_RESPONSE {
+    BAD_CONFIG = 1 << 0,
+}
+const EXEC_RESPONSE_MAP: { [index: number]: string } = {
+    1: 'bad_config',
+};
+type execResponse = EXEC_RESPONSE;
+
 export default function readCiCdExec(
     repository: string,
     ref: string,
     type: string
-): string | undefined {
+): string | EXEC_RESPONSE | undefined {
     const jsonPath = './var/config/ci_cd.json';
     let ciCd = undefined;
 
@@ -16,7 +24,7 @@ export default function readCiCdExec(
         const message =
             'An error occured while trying to parse "./var/config/ci_cd.json", check for invalid syntax and run the program again. (Check error logs)';
         console.log('[helmsman]'.red, message, error);
-        return 'bad_config';
+        return EXEC_RESPONSE.BAD_CONFIG;
     }
     const [, branch] = /refs\/heads\/(.*)$/.exec(ref) || [];
     const repositoryBranch = `${repository}/${branch}`;
@@ -29,3 +37,6 @@ export default function readCiCdExec(
             ? ciCd[repositoryBranch][type]
             : undefined;
 }
+
+export { EXEC_RESPONSE, EXEC_RESPONSE_MAP };
+export type { execResponse };