Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't track raft logs #306

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

nicol-ii
Copy link
Contributor

Add generated raft logs to .gitignore

Copy link
Collaborator

@maurermi maurermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T-ACK; This change simply adds generated files to the .gitignore, so they are not mistakenly checked in during development. Assuming this passes CI tests, this should be good to go

@maurermi
Copy link
Collaborator

@HalosGhost I would say this is good to go, but will defer to you on merging it in

Copy link
Collaborator

@HalosGhost HalosGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t-ACK. I'm happy to merge this, but it looks like it only covers the generated raft logs from parsec. I'd gladly also accept a PR to ignore the UHS architectures' raft logs (as well as all other files generated during our component runtimes).

Will Merge.

@HalosGhost HalosGhost merged commit bb46346 into mit-dci:trunk Oct 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants