Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populates first and late name, user created after email verification #40

Conversation

collinpreston
Copy link
Contributor

What are the relevant tickets?

#39

Description (What does it do?)

  1. Maps Keycloak user's first and last name to the correct attributes in the SCIM extension. This ensures that all SCIM requests for creating users will include the first and last name.
  2. Users are only provisioned via SCIM when they have verified their email address.

How can this be tested?

Setup

  1. Keycloak running locally.
  2. This branch is built and the resulting jar file is placed within the "providers" folder in your keycloak instance. (instructions: https://docs.google.com/document/d/17tJ-C2EwWoSpJWZKjuhMVgsqGtyPH0IN9KakXvSKU0M/edit?pli=1#heading=h.k62uq36ldhsa)
  3. MIT Open is running locally. An admin user is created and an access token, like the one shown below, is created.
    Screenshot 2024-03-08 at 10 10 15 AM
  4. Your local instance of Keycloak is configured with the ol login theme, browser flow matching what is in QA as of this PRs creation date, SMTP email provider configured, and SCIM federation is configured to work with your local MIT Open instance, shown below.
    Screenshot 2024-03-08 at 10 12 07 AM

Test

  1. Follow the registration flow in Keycloak.
  2. Before completing the email verification step, verify that no user has been provisioned in MIT Open via SCIM.
  3. After completing the email verification step, verify that a user has been provisioned in MIT Open via SCIM. Verify that the user has their first and last name populated.

@collinpreston collinpreston added the Needs Review An open Pull Request that is ready for review label Mar 8, 2024
Copy link

@rhysyngsun rhysyngsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhysyngsun rhysyngsun added Waiting on Author and removed Needs Review An open Pull Request that is ready for review labels Mar 14, 2024
@collinpreston collinpreston merged commit 5ff00b4 into main Mar 15, 2024
1 check passed
@collinpreston collinpreston deleted the 39-SCIM-requests-include-first-and-last-name,-is_active-is-false-when-email-is-not-verified branch March 15, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants