Removes instances where we've feature flagged the new (current) design #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinpreston
suggested changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes #1864
Description (What does it do?)
This removes remnants of the old MITx Online visual design and eliminates checks for the feature flag that toggled between the two designs. It keeps the code that allows for checking for feature flags in the front end.
#1864 also specifies removing CSS and images from the old design but some pages still use elements of the old design, so this isn't done here.
How can this be tested?
Test against RC or production. The look and feel should not change; all UI elements should be there; there should be no changes for accessibility. Turning the new design off by flipping the feature flags, or blocking Posthog in some method (e.g. via an ad blocker), should not revert you back to the old design.