-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.85.0 #2067
Merged
Merged
Release 0.85.0 #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#2030) * Redid the upgrade on a new branch because I had weird dependency issues. * before jest-codemods * update for lifecycle methods mounting * test updates * mock useContext for shallow rendered tests * change to shallow helper with chris's mock * putting away to test pr * added comment to top of scratch file * put main containers back on deep render * notification container back to deep render * remove extra console.log statements and addd in second describe statement in CourseProductDetailEnroll_test.js to facilitate splitting tests per render method * moved all tests that were unable to make calls due to shallow render over to a separate block which calls deeprender only. Have to put changes back in to fix teh generated course data and should be set. * fix some linting issues * fix some linting issues * I totally forgot to reinstall pre-commit after I reinstalled linux on this. fmt * fix flow * move Response location * move flow up to root * response == queryresponse? * updated components with links. need actual links. * fix flow errors (#2051) * test updates to passing - moved a lot of tests to just test the behavior, shallowly, ignoring any calls. we otherwise test that these components are working with redux (which is what makes those calls that were previously asserted by sinon. Now I'm taking those as fact since we want to test the behavior of this component with the information provided, this is a shallow render, ignoring those calls (and un-complicating the test) * format * unused imports * Revert "updated components with links. need actual links." This reverts commit fd4163f. * fixes for poor merge on the tests - and related formatting * PR response fixes * fix fmt --------- Co-authored-by: Chris Chudzicki <[email protected]>
* No opacity on program card, pointer when hovering * Transition text, image cover black to opaque
…alert (#2059) * delay alert when rendering the page * format * lint * format success * Change to 500ms and comment
* remove enrolled state and change the enrollable sort * format * remove test * remove test * remove test * validate paid enrollment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collin Preston
Rachel Lougee
James Kachel
Anna Gavrilman
jenniw