Updates the course about page CSS #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't conditionally apply styles. Instead, always include the v2 styles (in product-page/). - New styles are wrapped to only take effect if the body tag has the `new-design` class (which does get toggled by the feature flag) - Started on removing duplication but will take a bit The plan is to just leave the new design specific stuff wrapped in the body.new-design and then when it's time to eliminate the flag, pull that wrapper then use a linter or something to find the classes that aren't being used anymore.
JenniWhitman
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
#1862
Description (What does it do?)
This wraps the feature-flagged class changes (and just those changes) in a selector that should only apply if the feature flag is tagged on.
How can this be tested?
Set the feature flag to Enabled and check - it should look the same as it did in #1816 .
Set the feature flag to Disabled and check - it should successfully revert to the old design.