Updating video player CSS to work better in the new design #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. by making it actually exist there. Also includes some sizing tweaks for the new sidecard layout (especially for HLS videos).
rachellougee
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes #1880
Description (What does it do?)
The relevant VideoJS CSS was located in a set of CSS selectors that meant it wouldn't be applied on the new design product page, which broke the player. This moves those styles where they will apply, and makes some tweaks to the styles to make videos fit better in the sidebar.
This also adds a new
videojstag that can be used to drop our standard VideoJS tag, and will allow us to make global changes to this (as we'll be able to update the tag template in one place).Screenshots (if appropriate):
YouTube embed:
HLS embed:
How can this be tested?
Set up a course with a video URL. Viewing the course should give you a play button and video controls (in some fashion - embedded ones for HLS video, YouTube ones for a YouTube video).