Updates the code behind the More Dates selector to work without the course page #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't think so - I updated the template to filter out runs that aren't live in 8081f98 |
jkachel
force-pushed
the
jkachel/hq-2396-fix-for-more-dates-dropdown
branch
from
fda9ce3 to
c7e16d3
Compare
|
Pulled the live filtering - we can address that in a separate PR (per Slack convo) since the better way to do this potentially changes other things. |
collinpreston
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The course page was removed from the courserun API response in an earlier PR, but the More Dates selector depended on it being there to determine which course run to show you. This PR changes that logic to something more simple - either you've selected a course run or you haven't.
What are the relevant tickets?
Fixes mitol/hq#2396 partially
Description (What does it do?)
If a course run has been selected, use that instead of the default (which is just the first courserun that appears in the list when we go to fetch them).
How can this be tested?
Set up a course with multiple concurrent runs. (For my testing, I made two with run tags ending in A and B so it'd be obvious which is which.) Then, load the course page. You should see the More Dates selector.
Clicking Enroll Now without choosing a course in the More Dates selector should enroll you in the first course on the list.
Choosing a course from the More Dates selector and then clicking Enroll Now should enroll you in that specific course run.
Additional Context
Your Enroll Now button may not change to Enrolled depending on whether or not you have a working edX instance and a corresponding course there for your test course runs. For example, I am enrolled in both these courses. However, Tutor isn't aware of either - I set one manually to be EdX Enrolled = True. (These screenshots also demonstrate that the selector works.)