-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2116 improve resilience of posthog integration #2148
2116 improve resilience of posthog integration #2148
Conversation
I was looking through this and it seems pretty close to the implementation that's in Open. Rather than squaring these two implementations up, should they be merged and put instead into ol-django's common app? That way MITx Online and Open will have consistent implementations (and MITx Online would gain a local feature flag cache). Thoughts? |
Sure that sounds good. |
Closing in favor of mitodl/ol-django#152 which will be followed up with an accompanying MITx Online PR to incorporate the ol-django PR. |
What are the relevant tickets?
#2116
Description (What does it do?)
POSTHOG_FEATURE_FLAG_REQUEST_TIMEOUT_MS
as an environment variable. Default is 3000 milliseconds.POSTHOG_MAX_RETRIES
as an environment variable. Default is 3.feature_flags_request_timeout_seconds
as an option when calling PostHog (https://posthog.com/docs/feature-flags/adding-feature-flag-code#request-timeout).Testing
POSTHOG_FEATURE_FLAG_REQUEST_TIMEOUT_MS=1
in your .env file and restart MITx Online. When you load the homepage you should not see any features that require the feature flags to be active.POSTHOG_FEATURE_FLAG_REQUEST_TIMEOUT_MS=3000
in your .env file and restart MITx Online. When you load the homepage you should see features that require the feature flags to be active.