resolved change requests

mitodl · May 30, 2024 · 39b96c4 · 39b96c4
1 parent fe70f63
commit 39b96c4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/videos/constants.py b/videos/constants.py
@@ -15,7 +15,7 @@
 WEBVTT_FORMAT_ID = 51
 
 TRANSCODE_JOB_SUBSCRIPTION_URL = "https://sns.{AWS_REGION}.amazonaws.com/?Action=ConfirmSubscription&TopicArn=arn:aws:sns:{AWS_REGION}:{AWS_ACCOUNT_ID}:MediaConvertJobAlert&Token={TOKEN}"
-BAD_REQUEST_MSG = "Token Cannot be empty!"
+BAD_REQUEST_MSG = "Token cannot be empty!"
 
 
 class VideoStatus:

diff --git a/videos/exceptions.py b/videos/exceptions.py
@@ -5,7 +5,7 @@
 
 
 class BadRequest(APIException):
-    """Exception for Invalid request data"""
+    """Exception for invalid request data"""
 
     status_code = status.HTTP_400_BAD_REQUEST
     default_detail = "Bad request."

diff --git a/videos/utils_test.py b/videos/utils_test.py
@@ -103,7 +103,7 @@ def test_create_new_content(mocker):
 
 
 def test_get_subscribe_url(mocker):
-    """Test for get_subscribe_url method"""
+    """Test get_subscribe_url to format ConfirmSubscription url correctly"""
 
     mocker.patch("django.conf.settings.AWS_REGION", "us-east-1")
     mocker.patch("django.conf.settings.AWS_ACCOUNT_ID", "1234567890")

diff --git a/videos/views_test.py b/videos/views_test.py
@@ -7,6 +7,7 @@
 import pytest
 from django.http.response import HttpResponse
 from django.urls import reverse
+from rest_framework.status import HTTP_400_BAD_REQUEST
 
 from gdrive_sync.factories import DriveFileFactory
 from users.factories import UserFactory
@@ -102,7 +103,7 @@ def test_transcode_jobs_wrong_account(drf_client):
 
 
 def test_transcode_jobs_subscribe(settings, mocker, drf_client):
-    """TranscodeJobView should confirm a subcsription request"""
+    """TranscodeJobView should confirm a subscription request"""
     mock_get = mocker.patch("videos.views.requests.get")
     with open(  # noqa: PTH123
         f"{TEST_VIDEOS_WEBHOOK_PATH}/subscribe.json", encoding="utf-8"
@@ -149,7 +150,7 @@ def test_transcode_jobs_subscribe_bad_request(settings, mocker, drf_client):
     data["Token"] = ""
 
     response = drf_client.post(reverse("transcode_jobs"), data=data)
-    assert response.status_code == 400
+    assert response.status_code == HTTP_400_BAD_REQUEST
     mock_get.assert_not_called()