Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.47.9 #1064

Merged
merged 9 commits into from
Feb 25, 2022
Merged

Release 0.47.9 #1064

merged 9 commits into from
Feb 25, 2022

Conversation

odlbot
Copy link
Contributor

@odlbot odlbot commented Feb 25, 2022

Chris Chudzicki

Matt Bertrand

Anastasia Beglova

mbertrand and others added 9 commits February 24, 2022 08:20
Convert baseurl with document fragments in markdown_cleanup
determine ResourcePickerDialog tabs from site config

Motivation: We want to show collection tabs only in ocw-www for now, and resource/page tabs only on course sites for now.

**Why only link collections in ocw-www?** Because linking to collections in `ocw-www` sites is the immediate need and ... right now there are some mismatches between `ocw-course` and `ocw-www` configurations which would make linking to other things (pages, resources) a bit annoying. For example, in courses, pages have `type=page`, but in www they have `type=pages`. And in courses, resource types are determined by `resourcename` but in `www` they are determined by `filename`.
In #1036 we began encoding the data-uuid argument for < resource_link > shortcodes. The encoding / decoding worked fine for converting between HTML and Markdown.

But in that PR I forgot to encode the data we passed to CKEditor when creating new links.
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #1064 (6a19d4a) into release (b943040) will increase coverage by 0.03%.
The diff coverage is 92.30%.

Impacted file tree graph

@@             Coverage Diff             @@
##           release    #1064      +/-   ##
===========================================
+ Coverage    91.13%   91.17%   +0.03%     
===========================================
  Files          201      201              
  Lines         7679     7713      +34     
  Branches      1332     1336       +4     
===========================================
+ Hits          6998     7032      +34     
+ Misses         596      594       -2     
- Partials        85       87       +2     
Impacted Files Coverage Δ
content_sync/pipelines/concourse.py 90.90% <ø> (ø)
static/js/components/PublishDrawer.tsx 100.00% <ø> (ø)
static/js/pages/MarkdownEditorTestPage.tsx 27.77% <ø> (ø)
static/js/types/websites.ts 100.00% <ø> (ø)
static/js/lib/ckeditor/CKEditor.ts 91.17% <57.14%> (-8.83%) ⬇️
...s/management/commands/markdown_cleaning/cleaner.py 70.21% <62.50%> (-1.59%) ⬇️
main/settings.py 94.33% <100.00%> (+0.08%) ⬆️
main/utils.py 100.00% <100.00%> (ø)
static/js/components/widgets/MarkdownEditor.tsx 94.11% <100.00%> (+12.48%) ⬆️
...tic/js/components/widgets/ResourcePickerDialog.tsx 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b943040...6a19d4a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants