improve link logging #1235
Merged
improve link logging #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1235 +/- ##
==========================================
- Coverage 90.74% 90.68% -0.06%
==========================================
Files 212 212
Lines 8839 8850 +11
Branches 1634 1635 +1
==========================================
+ Hits 8021 8026 +5
- Misses 709 715 +6
Partials 109 109
Continue to review full report at Codecov.
|
ChristopherChudzicki
force-pushed
the
cc/link-logger
branch
2 times, most recently
from
73b6dd8 to
1d6d604
Compare
ChristopherChudzicki
force-pushed
the
cc/link-logger
branch
from
1d6d604 to
11280af
Compare
mbertrand
requested changes
Apr 12, 2022
Comment on lines
+18
to
+36
| def get_ocw_url(content: WebsiteContent): | ||
| """Return an ocw.mit.edu url to the given content.""" | ||
| rootrel = get_rootrelative_url_from_content(content) | ||
| return f"https://ocw.mit.edu{rootrel}" | ||
|
|
||
|
|
||
| def get_studio_url(content: WebsiteContent): | ||
| """Return an ocw-studio.odl.mit.edu url to the given content.""" | ||
| site_name = content.website.name | ||
| if content.type == "sitemetadata": | ||
| return f"https://ocw-studio.odl.mit.edu/sites/{site_name}/type/metadata/" | ||
| return f"https://ocw-studio.odl.mit.edu/sites/{site_name}/type/page/edit/{content.text_id}/" | ||
|
|
||
|
|
||
| def get_github_url(content: WebsiteContent): | ||
| """Return a github.mit.edu url to the given content.""" | ||
| short_id = content.website.short_id | ||
| return f"https://github.mit.edu/mitocwcontent/{short_id}/tree/main/{content.dirpath}/{content.filename}.md" | ||
|
|
There was a problem hiding this comment.
Might be better to use django settings for the domains instead of hardcoding them. For example:
OCW_STUDIO_BASE_URL for the OCW Studio domain
GIT_DOMAIN for the github domain
OCW_STUDIO_LIVE_URL for ocwnext, though this isn't ocw.mit.edu on production (it's https://ocw-published.odl.mit.edu/ instead - maybe that should be changed?) but should lead to the same place.
mbertrand
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Flight checklist
What are the relevant tickets?
None
What's this PR do?
Miscellaneous improvements to the output of
markdown_cleanupand link logging rule that I made when opening #1233:--limitoption for the management command, useful for testingHow should this be manually tested?
Run
and check that the links in the CSV work.