Release 0.63.4 #1399
Closed
Release 0.63.4 #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tldr: Because we do not use them and they cause some ts errors in IDEs (that we suppress during CLI through `--noEmit`). We currently have an error > Exported variable 'getWebsiteDetailCursor' has or is using name '$CombinedState' from external module "/Users/chudzick/dev/ocw-studio/node_modules/redux/index" but cannot be named. See microsoft/TypeScript#5711 for some info about this error. Manually importing $CombinedState both seems silly and does not fix the issue (I think `re-select` would need to import it itself? I'm not sure. Possibly related to microsoft/TypeScript#5711 (comment)) The error: - is visible in some IDEs (e.g., VS Code) - does not show up when running `npm run typecheck` since that uses the `--noEmit` CLI flag, which suppresses both compiled code and declarations from being emitted. But our tsconfig does specify that declarations can be made...I'm not sure why. As I understand it, the setting makes sense for a library but not for an app.
* add PublishingOption component
replace two more constants with enums
* tweak unique url error message
* improve IntegrationTestHelper
specifically:
- use spyOn to mock makeRequest, rather than a global mock. The global mock was being problematic when other imports (e.g., the old integration test helper) was also mocking `makeRequest`.
- add `mockGetWebsiteDetail`
- make `helper.mockRequest` more flexible in its argument matching
* show form errors in PublishForm
* remove old error test
* fix PublishForm import
* format python changes
…1363) * update generate_item_metadata to optionally use config default value * no default kwarg dict value * fix test_update_youtube_statuses
Codecov Report
@@ Coverage Diff @@
## release #1399 +/- ##
===========================================
+ Coverage 89.10% 89.12% +0.01%
===========================================
Files 232 232
Lines 9733 9778 +45
Branches 1843 1838 -5
===========================================
+ Hits 8673 8715 +42
- Misses 932 933 +1
- Partials 128 130 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matt Bertrand
Chris Chudzicki