Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HTTP status codes for external resources #2199

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

pt2302
Copy link
Contributor

@pt2302 pt2302 commented Jun 3, 2024

What are the relevant tickets?

Closes #2198.

Description (What does it do?)

This PR updates the constants for external resources to use rest_framework.status imports rather than defining the constants directly, to be consistent with the usage elsewhere in the ocw-studio codebase.

How can this be tested?

No functionality is affected by this PR. However, for completeness, test that the external resource link-checking functionality is not affected by following the same testing instructions as for #2171.

@pt2302 pt2302 mentioned this pull request Jun 3, 2024
@umar8hassan umar8hassan self-assigned this Jun 4, 2024
@umar8hassan umar8hassan self-requested a review June 4, 2024 21:31
Copy link
Contributor

@umar8hassan umar8hassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@umar8hassan umar8hassan assigned pt2302 and unassigned umar8hassan Jun 5, 2024
@pt2302 pt2302 merged commit 40d2aeb into master Jun 5, 2024
7 checks passed
@pt2302 pt2302 deleted the pt/http_status_codes branch June 5, 2024 14:44
@odlbot odlbot mentioned this pull request Jun 6, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor HTTP code constants for external resources
2 participants