-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Management command for gdrive file sync #2257
Management command for gdrive file sync #2257
Conversation
@@ -10,3 +10,5 @@ | |||
|
|||
PRIORITY_STEPS = 5 # priority range (0 - 4) | |||
DEFAULT_PRIORITY = 2 # Half step of range (0 - 4) | |||
|
|||
IS_FILTER_REQUIRED = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand the reason for making this an app-wide setting. Could you please explain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The required
is False
app-wide by default. With this approach we could make filter required for any existing or new commands by only setting the IS_FILTER_REQUIRED
param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just replace log.info
with self.stdout.write
and replace log.exception
with self.stderr.write
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What are the relevant tickets?
Fixes #4910
Description (What does it do?)
Management command to Re-Process a broken resource from Drive.
How can this be tested?
umar/4910-video-resource-incomplete-after-syncing
and spin-up containersvideos_final
docker-compose exec web ./manage.py sync_gdrive_files --filter course-id --filename filename1
Drivefile
Object. It should be updated.