Allow for null checksums returned by Google Drive, ignore files without download links #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbertrand
force-pushed
the
mb/null_checksums
branch
from
7f3bcbd to
43dc7c8
Compare
mbertrand
changed the title
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
=======================================
Coverage 91.09% 91.10%
=======================================
Files 177 177
Lines 6493 6496 +3
Branches 991 991
=======================================
+ Hits 5915 5918 +3
Misses 504 504
Partials 74 74
Continue to review full report at Codecov.
|
mbertrand
force-pushed
the
mb/null_checksums
branch
from
43dc7c8 to
4c52c84
Compare
mbertrand
force-pushed
the
mb/null_checksums
branch
from
4c52c84 to
5a8a0fc
Compare
mbertrand
force-pushed
the
mb/null_checksums
branch
from
5a8a0fc to
6cacde5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Flight checklist
What are the relevant tickets?
Closes #648
What's this PR do?
Allows
DriveFile.checksumto be null because that's what Google Drive returns for some files.Ignores any files that have null download links (because that link is used to upload to S3).
Also surrounds the body of
gdrive_sync.api.process_file_resultto log any errors instead of raising them.How should this be manually tested?
files_finalsubfolder beneath your site's folder in google drive. Also upload some other files there.Any background context you want to provide?
Since I'm not 100% positive that null checksums occur only for native google drive files without download links, I changed the code to allow those through as long as they have that download link. But S3 uploads require the download link, so those files will be ignored. Support for native google docs/sheets will be added later (#668).