Fix factory to better define a user, fix serializer (AnonymousUser do…

…esn't have an email)

unified_ecommerce/factories.py

@@ -3,19 +3,24 @@
 """
 
 import ulid
-from django.contrib.auth.models import Group, User
-from factory import LazyFunction, RelatedFactory
+from django.contrib.auth import get_user_model
+from django.contrib.auth.models import Group
+from factory import Faker, LazyFunction, RelatedFactory
 from factory.django import DjangoModelFactory
 from factory.fuzzy import FuzzyText
 
+User = get_user_model()
+
 
 class UserFactory(DjangoModelFactory):
     """Factory for Users"""
 
+    global_id = Faker("uuid4")
     username = LazyFunction(lambda: ulid.new().str)
     email = FuzzyText(suffix="@example.com")
     first_name = FuzzyText()
     last_name = FuzzyText()
+    is_active = True
 
     profile = RelatedFactory("users.factories.UserProfileFactory", "user")
 

unified_ecommerce/serializers.py

@@ -9,8 +9,22 @@
 class UserSerializer(serializers.ModelSerializer):
     """Serializer for User model."""
 
+    email = serializers.SerializerMethodField()
+
+    def get_email(self, instance):
+        """Return the email."""
+        return instance.email if not instance.is_anonymous else None
+
     class Meta:
         """Meta class for serializer."""
 
         model = User
-        fields = ["id", "username", "email", "first_name", "last_name"]
+        fields = [
+            "id",
+            "global_id",
+            "username",
+            "email",
+            "first_name",
+            "last_name",
+            "name",
+        ]

users/views_test.py

@@ -21,6 +21,7 @@ def test_current_user(user, client, user_client):
     assert resp.json() == {
         "id": None,
         "username": "",
+        "email": None,
     }
 
     resp = user_client.get(me_api)