Neuvector mapper #6195
Merged
Neuvector mapper #6195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtquach1
force-pushed
the
neuvector-mapper
branch
5 times, most recently
from
0a110f7 to
c86d212
Compare
|
Does this have both forward and backwards conversion? |
@Amndeep7 mentioned I didn't need to do backwards conversion (forwards conversion only). I didn't make a PR against saf-cli yet, but going to put that up and link/reference here |
Amndeep7
requested changes
Sep 26, 2024
libs/hdf-converters/sample_jsons/neuvector_mapper/sample_input_report/neuvector-1.json
Outdated
Show resolved
Hide resolved
libs/hdf-converters/test/mappers/forward/neuvector_mapper.spec.ts
Outdated
Show resolved
Hide resolved
libs/hdf-converters/test/mappers/forward/neuvector_mapper.spec.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
…r, and CVE status tags Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
….name is not a unique identifier, and incorporate envs and cmds into tags Signed-off-by: Joyce Quach <[email protected]>
…and make CIS benchmark check status skipped instead of failed Signed-off-by: Joyce Quach <[email protected]>
…up if they are falsy Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
…pper to support RHSA tags Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
…text Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
jtquach1
force-pushed
the
neuvector-mapper
branch
from
0803ddf to
efbdfb7
Compare
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Amndeep7
requested changes
Sep 26, 2024
libs/hdf-converters/test/mappers/forward/neuvector_mapper.spec.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
…r tweaks Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Amndeep7
approved these changes
Sep 27, 2024
|
aaronlippold
pushed a commit
that referenced
this pull request
Nov 20, 2024
* Initial commit with skeleton mapper Signed-off-by: Joyce Quach <[email protected]> * Modify fingerprints and update neuvector-mapper.ts Signed-off-by: Joyce Quach <[email protected]> * Update tags and impact Signed-off-by: Joyce Quach <[email protected]> * Add impact mapping and results message Signed-off-by: Joyce Quach <[email protected]> * Update results message Signed-off-by: Joyce Quach <[email protected]> * Add CVSS tag Signed-off-by: Joyce Quach <[email protected]> * Update nist, cwe, and cvss tags Signed-off-by: Joyce Quach <[email protected]> * Add severity field and update NIST tags Signed-off-by: Joyce Quach <[email protected]> * Add source tag of CVE and edit cve tags Signed-off-by: Joyce Quach <[email protected]> * Add comment and export Signed-off-by: Joyce Quach <[email protected]> * Update comment about types Signed-off-by: Joyce Quach <[email protected]> * Add cve status tag Signed-off-by: Joyce Quach <[email protected]> * Update impact and add new security risk score, CVSS score, CVSS vector, and CVE status tags Signed-off-by: Joyce Quach <[email protected]> * Fix code smells Signed-off-by: Joyce Quach <[email protected]> * Incorporate report.checks into profile.controls Signed-off-by: Joyce Quach <[email protected]> * Remove boilerplate comments Signed-off-by: Joyce Quach <[email protected]> * Update profile.controls related to report.checks Signed-off-by: Joyce Quach <[email protected]> * Add CVSS non-v3 vectors and create mappings for start_time and run_time Signed-off-by: Joyce Quach <[email protected]> * Update impact, tags, and especially id because report.vulnerabilities.name is not a unique identifier, and incorporate envs and cmds into tags Signed-off-by: Joyce Quach <[email protected]> * Rename CVSS v2 and v3 related tags to original parlance in Neuvector and make CIS benchmark check status skipped instead of failed Signed-off-by: Joyce Quach <[email protected]> * Add more tags, change cve tag to cves, make optional fields not show up if they are falsy Signed-off-by: Joyce Quach <[email protected]> * Delete old JSONs Signed-off-by: Joyce Quach <[email protected]> * Add input Neuvector JSONs Signed-off-by: Joyce Quach <[email protected]> * Add new/updated withraw JSONs Signed-off-by: Joyce Quach <[email protected]> * Add Neuvector input/output JSONs that include RHSA tags and update mapper to support RHSA tags Signed-off-by: Joyce Quach <[email protected]> * Fix code smells Signed-off-by: Joyce Quach <[email protected]> * Include Docker image and version in profiles and tweak report.checks text Signed-off-by: Joyce Quach <[email protected]> * Revert changes for including report.checks and report.base_os Signed-off-by: Joyce Quach <[email protected]> * Comment out writing of Neuvector HDF JSON files in spec Signed-off-by: Joyce Quach <[email protected]> * Fix eslint error and warning Signed-off-by: Joyce Quach <[email protected]> * Add changes based on review comments part 1 Signed-off-by: Joyce Quach <[email protected]> * Revert changes to cmds and envs and edit comment in NeuVector types file Signed-off-by: Joyce Quach <[email protected]> * Fill out profiles.title Signed-off-by: Joyce Quach <[email protected]> * Fill out auxiliary_data and simplify tags Signed-off-by: Joyce Quach <[email protected]> * Separate out input JSONs into their own it blocks Signed-off-by: Joyce Quach <[email protected]> * Remove unused variable Signed-off-by: Joyce Quach <[email protected]> * Properly memoize getModules and revert change to Anchore grype mapper Signed-off-by: Joyce Quach <[email protected]> * Add HDF title field, fix formatting of Dockerfile cmds and envs, other tweaks Signed-off-by: Joyce Quach <[email protected]> * Fix code smell Signed-off-by: Joyce Quach <[email protected]> --------- Signed-off-by: Joyce Quach <[email protected]> Co-authored-by: Amndeep Singh Mann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to mitre/saf#2912