Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Apply Attestation: "TypeError: Cannot read properties of undefined (reading 'status')" #6616

Merged
merged 7 commits into from
Feb 13, 2025
Merged

Fix Apply Attestation: "TypeError: Cannot read properties of undefined (reading 'status')" #6616

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
43fc588
added a catch for overlay files which may have controls with no resul…
em-c-rod Feb 10, 2025
b771f8f
lint
em-c-rod Feb 11, 2025
7783c66
cleaned up function as a whole
Amndeep7 Feb 11, 2025
2bdba36
adding a test
em-c-rod Feb 12, 2025
bdd447a
updated error message and linting in test
em-c-rod Feb 13, 2025
df343fa
update the test to check for both attestations to be applied
em-c-rod Feb 13, 2025
831da43
Merge branch 'master' into ApplyAttestationToOverlay
em-c-rod Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion libs/hdf-converters/src/utils/attestations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,10 @@ function attestationCanBeAdded(
control: ExecJSON.Control
) {
if (attestation.control_id.toLowerCase() === control.id.toLowerCase()) {
if (control.results[0].status === 'skipped') {
if (control.results.length === 0) {
// There are no results for this control. It may be part of an overlay file.
return false;
} else if (control.results[0].status === 'skipped') {
return true;
} else {
console.error(
Expand Down
Loading