-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OS Release Comparing: 8.10 #39
base: main
Are you sure you want to change the base?
Conversation
Tested against 8.10. Regex for 8.1 and fails test. Should add End of Line for regex to differ 8.1 with 8.10
Please update the patch version in the |
each time we do a merge to main we have to update the version here so that inspec knows to pull down the updated code https://github.com/mitre/redhat-enterprise-linux-8-stig-baseline/blob/main/inspec.yml#L7C1-L7C16 |
The logic here is: version: 1.14.1 STIG Version 1 Release 14 of the benchmark generally and we have made .... 1,2,3 ... n patches and fixes to the test. Then we can make a set of releases v1.14.x -> v1.14 -> v1 So folks can 'pin' as they need to and don't 'run off main' in real workflows. https://mitre.github.io/saf-training/courses/profile-dev-test/02.html |
Will note for https://github.com/mitre/redhat-enterprise-linux-8-stig-baseline/tree/faillock_dir_dynamic branch upstream from this |
bump inspec version
I created a PR on the inspec side to fix this - inspec/inspec#7271 You may be able to just drop my udpated os resource into your profiles libraries directy to handle this as I took your approach and just moved it to the resource level vs the control level. |
Fixed by: inspec/inspec#7279 |
@aaronlippold what is the solution here? |
…review Signed-off-by: Aaron Lippold <[email protected]>
…s.version Signed-off-by: Aaron Lippold <[email protected]>
Signed-off-by: Aaron Lippold <[email protected]>
Signed-off-by: Aaron Lippold <[email protected]>
I updated the OS resource to do version correctly and updated all controls in the profile that were only for 8.1 or 8.2. I also put in a PR with inspec with it. Let me know if this works for you. |
@jrmetzger NOTE: pulling the os resource into the RHEL9 profile and making a similar update will be necessary until my PR with inspec - inspec/inspec#7294 is merged. |
Tested against 8.10 (modify /etc/os-release), working as expected |
…t in OS should not be needed, likey a local issue Signed-off-by: Aaron Lippold <[email protected]>
…t in OS should not be needed, likey a local issue Signed-off-by: Aaron Lippold <[email protected]>
Tested against 8.10. Regex for 8.1 and fails test. Should add End of Line for regex to differ 8.1 with 8.10