Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/miurahr/java17/re organize source tree #3

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

miurahr
Copy link
Owner

@miurahr miurahr commented Oct 15, 2022

Pull request type

Please mark github LABEL of the type of change your PR introduces:

  • Bug fix -> [bug]
  • Feature enhancement -> [enhancement]
  • Documentation -> [documentation]
  • Build and release changes -> [build/release]
  • Other (describe below)

Which ticket is resolved?

  • Title ex. fix...

    • URL ex. https://...
  • Title

    • URL

What does this PR change?

Other information

HTMLUtils methods are used in MosesTranslate.
This make dependency from MT connector to Filter driver.
This indicate the class is common utility so
refactor the class into org.omegat.util package.

- Rename it to org.omegat.util.HtmlUtils
- Deprecate org.omegat.filters2.html2.HTMLUtils class
  and refer to HtmlUtils for compatibility.

Signed-off-by: Hiroshi Miura <[email protected]>
TagValidationTool class depends on PoFilter class
to detect it is called from PoFilter.
A change drop import and check with class name
rather than class itself.

Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
- Update TMXWriterTest to check with system line separator
  It is because XML parser can automatically change /r/n into
  XML entity &#xD;/n when System.lineSeparator() is /n
- Update TMXReader2 to detect both "lang" and "xml:lang"
  some implementation return "lang" from "xml:lang" but
  other can return "xml:lang" as is.
- as a workaround for  FasterXML/jackson-modules-base#127
  Add  @JacksonXmlElementWrapper(useWrapping=false) for mask
  element for the parser of omegat.project file.

Signed-off-by: Hiroshi Miura <[email protected]>
- Ref: StAX parser in DGT-OmegaT

Signed-off-by: Hiroshi Miura <[email protected]>
Use OmegaT-DGT's SRX loader

Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr miurahr force-pushed the topic/miurahr/java17/re-organize-source-tree branch 2 times, most recently from a071c5f to 1d19107 Compare October 15, 2022 12:35
@sonatype-lift
Copy link

sonatype-lift bot commented Oct 15, 2022

⚠️ 55 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

@miurahr miurahr force-pushed the topic/miurahr/java17/re-organize-source-tree branch 6 times, most recently from 184ffb8 to 3bab399 Compare October 15, 2022 13:16
Signed-off-by: Hiroshi Miura <[email protected]>
- Support java17
- Support module

Signed-off-by: Hiroshi Miura <[email protected]>
@miurahr miurahr force-pushed the topic/miurahr/java17/re-organize-source-tree branch from 3bab399 to 913a5d9 Compare October 18, 2022 22:47
@@ -202,9 +204,10 @@ dependencies {
// Moses MT connector
implementation 'org.apache.xmlrpc:xmlrpc-client:3.1.3'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical Vulnerability:

pkg:maven/org.apache.xmlrpc/[email protected]

1 Critical, 1 High, 1 Medium, 0 Low, 0 None vulnerabilities have been found across 2 dependencies

To see more details about this component, go to the Sonatype Lift console


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

implementation "com.fasterxml.jackson.core:jackson-core:2.12.3"
implementation "com.fasterxml.jackson.core:jackson-databind:2.12.3"
implementation "com.fasterxml.jackson.dataformat:jackson-dataformat-xml:2.12.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High Vulnerability:

pkg:maven/com.fasterxml.jackson.dataformat/[email protected]

0 Critical, 4 High, 0 Medium, 0 Low, 0 None vulnerabilities have been found across 1 dependencies

To see more details about this component, go to the Sonatype Lift console


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant