fix beatjump description and beatsize range
#611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holzhaus
approved these changes
Feb 17, 2024
| @@ -510,9 +512,9 @@ Any control listed above for :mixxx:cogroupref:`[ChannelN]` will work for a samp | |||
| [PreviewDeckN],beatjump | |||
| [SamplerN],beatjump | |||
|
|
|||
| Jump forward by :mixxx:coref:`beatjump_size <[ChannelN],beatjump_size>` (positive) or backward by :mixxx:coref:`beatjump_size <[ChannelN],beatjump_size>` (negative). If a loop is active, the loop is moved by :mixxx:coref:`beatjump_size <[ChannelN],beatjump_size>`. | |||
| Jump forward (positive) or backward (negative) by N beats. If a loop is active, the loop is moved by X beats. | |||
There was a problem hiding this comment.
Might make sense to split these long lines and put each sentence on a separate lines if you touch them anyway. Your decision.
There was a problem hiding this comment.
I'm not sure whether the line breaks would really be helpful here. If applied consistently for all controls, the page would grow enormously when being viewed on mobile screens.
There was a problem hiding this comment.
Oh, I meant regular line break to make diff nicer to read. I thought this was not make da difference in the resulting html unless you put a blank line in between. Is that incorrect?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.