document shift_cues_earlier/_later(_small) ControlObjects

[Swiftb0y]

No description provided.

[Swiftb0y]

idk why the build failed. I can't reproduce locally. Should I rebase onto 2.4 since 2.3 doesn't get updated anyway?

[ronso0]

Note that this moves all cues. IIRC the intention is to compensate for decoder offsets.
https://github.com/mixxxdj/mixxx/blob/9b31059fbacdd2d66bcf397b2354bb32c7ad1872/src/track/track.cpp#L978

[ronso0]

Should I rebase onto 2.4 since 2.3 doesn't get updated anyway?

Yup!

[Swiftb0y]

done. please rereview @ronso0 ;)

[ronso0]

Note that this moves all cues.

I meant it moves all cue points: hotcues, saved loops, main cue, intro, outro (but not the temp. loop).
(well, the GUI button in skin settings is labeled 'Hotcue Shift buttons' ...)

[Swiftb0y]

right... so what text would you prefer then? Can you make a suggestion?

[ronso0]

how about this?
Only downside is that we can not link to :term:.
Not sure if we should link to djing_with_mixxx#intro-and-outro-cues AND :term:cue AND :term:hotcues ?

Suggested change

	:feedback: All :term:`hotcues <hotcue>` move left by 10ms.
	:feedback: All cue markers move left by 10ms.

[Swiftb0y]

we could also just add a glossary entry for "cue marker" which in turn links to those?

[ronso0]

of course 🙄 I'd prefer that, too

[Swiftb0y]

Done

[ronso0]

Perfect, thanks!

[Swiftb0y]

Thanks.