Skip to content

Commit

Permalink
(fix) Track Info: show key text as in tracks table
Browse files Browse the repository at this point in the history
  • Loading branch information
ronso0 committed Dec 16, 2024
1 parent 8f38975 commit 26c6d4b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
7 changes: 6 additions & 1 deletion src/library/dlgtrackinfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -744,7 +744,12 @@ mixxx::UpdateResult DlgTrackInfo::updateKeyText() {
}

void DlgTrackInfo::displayKeyText() {
const QString keyText = KeyUtils::keyToString(m_trackRecord.getKeys().getGlobalKey());
QString keyText;
if (m_pLoadedTrack) {
keyText = KeyUtils::keyFromKeyTextAndIdValues(
m_pLoadedTrack->getKeyText(),
m_pLoadedTrack->getKey());
}
txtKey->setText(keyText);
}

Expand Down
6 changes: 5 additions & 1 deletion src/library/dlgtrackinfomulti.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,11 @@ void DlgTrackInfoMulti::updateTrackMetadataFields() {
composers.insert(rec.getMetadata().getTrackInfo().getComposer());
grouping.insert(rec.getMetadata().getTrackInfo().getGrouping());
years.insert(rec.getMetadata().getTrackInfo().getYear());
keys.insert(KeyUtils::keyToString(rec.getKeys().getGlobalKey()));
auto pTrack = getTrackFromSetById(rec.getId());
DEBUG_ASSERT(pTrack);
keys.insert(keyText = KeyUtils::keyFromKeyTextAndIdValues(

Check failure on line 391 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / clazy

use of undeclared identifier 'keyText'

Check failure on line 391 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / clang-tidy

use of undeclared identifier 'keyText' [clang-diagnostic-error]

Check failure on line 391 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / Ubuntu 22.04

‘keyText’ was not declared in this scope

Check failure on line 391 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / coverage

‘keyText’ was not declared in this scope

Check failure on line 391 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / macOS 13 x64

use of undeclared identifier 'keyText'

Check failure on line 391 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / macOS 13 arm64

use of undeclared identifier 'keyText'

Check failure on line 391 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / Windows 2019 (MSVC)

'keyText': undeclared identifier

Check failure on line 391 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / Windows 2019 (MSVC)

'KeyUtils::keyFromKeyTextAndIdValues': function does not take 1 arguments
m_pLoadedTrack->getKeyText(),

Check failure on line 392 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / clazy

use of undeclared identifier 'm_pLoadedTrack'

Check failure on line 392 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / clang-tidy

use of undeclared identifier 'm_pLoadedTrack' [clang-diagnostic-error]

Check failure on line 392 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / Ubuntu 22.04

‘m_pLoadedTrack’ was not declared in this scope; did you mean ‘m_pLoadedTracks’?

Check failure on line 392 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / coverage

‘m_pLoadedTrack’ was not declared in this scope; did you mean ‘m_pLoadedTracks’?

Check failure on line 392 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / macOS 13 x64

use of undeclared identifier 'm_pLoadedTrack'

Check failure on line 392 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / macOS 13 arm64

use of undeclared identifier 'm_pLoadedTrack'

Check failure on line 392 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / Windows 2019 (MSVC)

'm_pLoadedTrack': undeclared identifier
m_pLoadedTrack->getKey()));

Check failure on line 393 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / clazy

use of undeclared identifier 'm_pLoadedTrack'

Check failure on line 393 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / clang-tidy

use of undeclared identifier 'm_pLoadedTrack' [clang-diagnostic-error]

Check failure on line 393 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / macOS 13 x64

use of undeclared identifier 'm_pLoadedTrack'

Check failure on line 393 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / macOS 13 arm64

use of undeclared identifier 'm_pLoadedTrack'

Check failure on line 393 in src/library/dlgtrackinfomulti.cpp

View workflow job for this annotation

GitHub Actions / Windows 2019 (MSVC)

'm_pLoadedTrack': undeclared identifier
nums.insert(rec.getMetadata().getTrackInfo().getTrackNumber());
comments.insert(rec.getMetadata().getTrackInfo().getComment());

Expand Down

0 comments on commit 26c6d4b

Please sign in to comment.