Execute expensive setStleSheet only, if textcolor of BPM checkbox(pad…

…lock) changed
mixxxdj · Jun 10, 2024 · 623a704 · 623a704
1 parent 6d12418
commit 623a704
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/library/tabledelegates/bpmdelegate.cpp b/src/library/tabledelegates/bpmdelegate.cpp
@@ -50,6 +50,7 @@ BPMDelegate::BPMDelegate(QTableView* pTableView)
 #else
     m_pFactory->registerEditor(QVariant::Double, new BpmEditorCreator());
 #endif
+    m_cachedTextColor = QColor();
     setItemEditorFactory(m_pFactory);
 }
 
@@ -108,7 +109,9 @@ void BPMDelegate::paintItem(QPainter* painter,const QStyleOptionViewItem &option
             textColor = option.palette.color(QPalette::Normal, QPalette::Text);
         }
     }
-    if (textColor.isValid()) {
+
+    if (textColor.isValid() && textColor != m_cachedTextColor) {
+        m_cachedTextColor = textColor;
         m_pCheckBox->setStyleSheet(QStringLiteral(
                 "#LibraryBPMButton::item { color: %1; }")
                                            .arg(textColor.name(QColor::HexRgb)));

diff --git a/src/library/tabledelegates/bpmdelegate.h b/src/library/tabledelegates/bpmdelegate.h
@@ -17,4 +17,5 @@ class BPMDelegate : public TableItemDelegate {
   private:
     QCheckBox* m_pCheckBox;
     QItemEditorFactory* m_pFactory;
+    mutable QColor m_cachedTextColor;
 };