Only set a mapping dirty if the change is visible in the xml file.

mixxxdj · Jan 10, 2025 · f12d785 · f12d785
1 parent c70ca6f
commit f12d785
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/controllers/midi/legacymidicontrollermapping.cpp b/src/controllers/midi/legacymidicontrollermapping.cpp
@@ -13,7 +13,10 @@ bool LegacyMidiControllerMapping::isMappable() const {
 
 void LegacyMidiControllerMapping::addInputMapping(uint16_t key, const MidiInputMapping& mapping) {
     m_inputMappings.insert(key, mapping);
-    setDirty(true);
+    if (!std::holds_alternative<std::shared_ptr<QJSValue>>(mapping.control)) {
+        // Note: JS handler are not saved to the XML file
+        setDirty(true);
+    }
 }
 
 void LegacyMidiControllerMapping::removeInputMapping(uint16_t key) {