Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caluculation of m_resourcePath in the testing case #14110

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Jan 3, 2025

It took me quite a while to figure that out. A related issue is that the path/line reported in the error message is wrong, because of a QML hack:

https://github.com/mixxxdj/mixxx/blob/main/src/controllers/scripting/legacy/controllerscriptenginelegacy.cpp#L763-L765

The hack allows statements like this:

import "." as Skin

instead of

import "../qml" as Skin

I would prefer to remove the hack and use the later, which feels correct for me.

@acolombier
Copy link
Member

The reason for introducing this is to allow consistency with the QML code. As you can see with the S4 Mk3 PR, advanced mapping will likely consist of multiple QML file at different location, so I would rather allow some consistency on how you can import and reuse Mixxx component.

That being said, I agree that the current implementation is flawdd, and we should likely publish a QML module instead, which can be imported, along the lines of

import Mixxx.Skin 1.0 as Skin

@daschuer
Copy link
Member Author

daschuer commented Jan 9, 2025

Filed a bug for the pass issue #14151

Ready for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants