Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of rubocop-rspec (3.0.2) produced dependency conflicts #195

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jul 10, 2024

We've tried to upgrade a dependency and got errors running Bundler. It looks like there is a version conflict between two or more dependencies. Depfu doesn't try to solve these, as this would mean to update more than one dependency at a time.

Please take a look at the exact failure to figure out if this is something you need to work on.

The bundler error message was:

Bundler could not find compatible versions for gem "rubocop":
  In Gemfile:
    rubocop (= 1.60.2)

    rubocop-rspec (= 3.0.2) was resolved to 3.0.2, which depends on
      rubocop (~> 1.61)

What changed?

✳️ rubocop-rspec (2.26.1 → 3.0.2) · Repo · Changelog

Release Notes

3.0.2

  • Fix wrong autocorrect for RSpec/ScatteredSetup when hook contains heredoc. (@earlopain)
  • Fix false negative for RSpec/PredicateMatcher when expectation contains custom failure message. (@earlopain)
  • Facilitate the 3.0 upgrade flow with proper extracted cop messages. (@jeppester)

3.0.1

  • Bump RuboCop requirement to +1.61. (@ydah)

3.0.0

  • Remove extracted cops in Capybara, FactoryBot and Rails departments. (@ydah)
  • Remove RuboCop::RSpec::Language::NodePattern. (@ydah)
  • Remove RSpec/FilePath cop. (@ydah)
  • Remove RSpec/Capybara/FeatureMethods cop. If you are using this cop, change it to use RSpec/Dialect. (@ydah)
  • Add new RSpec/MissingExpectationTargetMethod cop. (@krororo)
  • Fix an error for RSpec/ScatteredSetup when one of the hooks is an empty block. (@earlopain)

These previously pending cops are now enabled by default: RSpec/BeEmpty, RSpec/BeEq, RSpec/BeNil, RSpec/ChangeByZero, RSpec/ClassCheck, RSpec/ContainExactly, RSpec/DuplicatedMetadata, RSpec/EmptyMetadata, RSpec/EmptyOutput, RSpec/Eq, RSpec/ExcessiveDocstringSpacing, RSpec/ExpectInLet, RSpec/IdenticalEqualityAssertion, RSpec/IndexedLet, RSpec/IsExpectedSpecify, RSpec/MatchArray, RSpec/MetadataStyle, RSpec/NoExpectationExample, RSpec/PendingWithoutReason, RSpec/ReceiveMessages, RSpec/RedundantAround, RSpec/RedundantPredicateMatcher, RSpec/RemoveConst, RSpec/RepeatedSubjectCall, RSpec/SkipBlockInsideExample, RSpec/SortMetadata, RSpec/SpecFilePathFormat, RSpec/SpecFilePathSuffix, RSpec/SubjectDeclaration, RSpec/UndescriptiveLiteralsDescription, and RSpec/VerifiedDoubleReference.

Read more about how to upgrade in https://docs.rubocop.org/rubocop-rspec/upgrade_to_version_3.html

2.31.0

  • Support AutoCorrect: contextual option for LSP. (@ydah)

2.30.0

  • Add new RSpec/ExpectInLet cop. (@yasu551)

2.29.2

  • Fix beginless and endless range bug for RepeatedIncludeExample cop. (@hasghari)
  • Fix a false positive for RSpec/RepeatedSubjectCall when subject is used as argument to function call. (@K-S-A)

2.29.1

  • Fix an error in the default configuration. (@ydah)

2.29.0

  • Fix an autocorrect error for RSpec/ExpectActual. (@bquorning)
  • Add new RSpec/UndescriptiveLiteralsDescription cop. (@ydah)
  • Add new RSpec/EmptyOutput cop. (@bquorning)

2.28.0

  • Extract RSpec Rails cops to a separate repository, rubocop-rspec_rails. The rubocop-rspec_rails repository is a dependency of rubocop-rspec and the cops related to rspec-rails are aliased (RSpec/Rails/Foo == RSpecRails/Foo) until v3.0 is released, so the change will be invisible to users until then. (@ydah)

2.27.1

  • Fix a false positive for RSpec/RepeatedSubjectCall when subject.method_call. (@ydah)
  • Add configuration option OnlyStaticConstants to RSpec/DescribedClass. (@ydah)

2.27.0

  • Add new RSpec/IsExpectedSpecify cop. (@ydah)
  • Add new RSpec/RepeatedSubjectCall cop. (@drcapulet)
  • Add support for assert_true, assert_false, assert_not_equal, assert_not_nil, *_empty, *_predicate, *_kind_of, *_in_delta, *_match, *_instance_of and *_includes assertions in RSpec/Rails/MinitestAssertions. (@ydah, @G-Rath)
  • Support asserts with messages in Rspec/BeEmpty. (@G-Rath)
  • Fix a false positive for RSpec/ExpectActual when used with rspec-rails routing matchers. (@naveg)
  • Add configuration option ResponseMethods to RSpec/Rails/HaveHttpStatus. (@ydah)
  • Fix a false negative for RSpec/DescribedClass when class with constant. (@ydah)
  • Fix a false positive for RSpec/ExampleWithoutDescription when specify with multi-line block and missing description. (@ydah)
  • Fix an incorrect autocorrect for RSpec/ChangeByZero when compound expectations with line break before .by(0). (@ydah)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jul 10, 2024
Copy link
Contributor Author

depfu bot commented Jul 31, 2024

Closed in favor of #196.

@depfu depfu bot closed this Jul 31, 2024
@depfu depfu bot deleted the depfu/update/rubocop-rspec-3.0.2 branch July 31, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants