Skip to content

Commit

Permalink
Support for Ruby 3.4 (#186)
Browse files Browse the repository at this point in the history
* Support for Ruby 3.4

* manually require logger

* add base64 and bigdecimal to gemfile (old as & new ruby)

* always

* rubocop -A

* remove explicit logger dependency

* also remove from gemfile

* nit: add comment

* move to gemfile
  • Loading branch information
klausmeyer authored Feb 19, 2025
1 parent 3fa1225 commit 5cfc448
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
fail-fast: false
matrix:
activesupport: ['6.1', '7.0', '7.1', '7.2']
ruby: ['3.1', '3.2', '3.3']
ruby: ['3.1', '3.2', '3.3', '3.4']
steps:
- uses: actions/checkout@v2
- name: Set up Ruby
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.3.3
3.4.2
7 changes: 7 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
source 'https://rubygems.org'

# Silence warning in ruby 3.4 (will no longer be part of the default gems starting from Ruby 3.5)
gem 'logger'

# Declare your gem's dependencies in keys-oauth.gemspec.
# Bundler will treat runtime dependencies like base dependencies, and
# development dependencies will be added by default to the :development group.
Expand All @@ -18,6 +21,10 @@ group :development, :test do
gem 'simplecov', '~> 0.16'
end

# Required for combination of old activesupport (< 7.1) and new ruby (> 3.3)
gem 'base64'
gem 'bigdecimal'

if (version = ENV['ACTIVESUPPORT'])
gem 'activesupport', "~> #{version}.0"
end
2 changes: 1 addition & 1 deletion ja2r.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Gem::Specification.new do |s|
s.homepage = 'https://github.com/mkon/ja2r'
s.summary = 'Simple JSON-API to ruby object conversion'
s.license = 'MIT'
s.required_ruby_version = '>= 3.1', '< 3.4'
s.required_ruby_version = '>= 3.1', '< 3.5'

s.files = Dir['{app,config,db,lib}/**/*', 'LICENSE', 'README.md']

Expand Down

0 comments on commit 5cfc448

Please sign in to comment.