Skip to content
This repository has been archived by the owner on Jan 27, 2023. It is now read-only.

LDAP binddn fix for OpenLDAP #133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

LDAP binddn fix for OpenLDAP #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c21aff
fix basedn for binduser
addy90 Nov 26, 2018
b52fd9b
new default for binduser fix
addy90 Nov 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions authenticate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,11 +296,11 @@

if (!empty($ldap_binduser_dn)) {
// Verify the given password
$ldap_sr_all_user_attributes = @ldap_search($ldap_connect, '', $ldap_filter_string);
$ldap_sr_all_user_attributes = @ldap_search($ldap_connect, $ldap_basedn, $ldap_filter_string);
$usersattributes = @ldap_get_entries($ldap_connect, $ldap_sr_all_user_attributes);
// try to connect to ldap using the given attribute and the password
if (!$ldap_bind_check_pass = ldap_bind($ldap_connect, $usersattributes[0][$ldap_userlogin_attr][0], $password)) {
sendError("Failed to authenticate: " . $usersattributes[0][$ldap_userlogin_attr][0]);
if (!$ldap_bind_check_pass = ldap_bind($ldap_connect, is_array($usersattributes[0][$ldap_userlogin_attr]) ? $usersattributes[0][$ldap_userlogin_attr][0] : $usersattributes[0][$ldap_userlogin_attr], $password)) {
sendError("Failed to authenticate: " . $usersattributes[0][$ldap_username_attr][0]);
} else {
// password is valid!
}
Expand Down
2 changes: 1 addition & 1 deletion ilibrarian-default.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ ldap_username_attr = "uid"
; Additional Active Directory Settings
;ldap_username_attr = "sAMAccountName"

ldap_userlogin_attr = "uid"
ldap_userlogin_attr = "dn"
; Additional Active Directory Settings
; attribute which is used to verify login/password pair
; ldap_userlogin_attr = "userprincipalname"
Expand Down