-
Notifications
You must be signed in to change notification settings - Fork 0
Sending Patches
Michal Toman edited this page Jun 29, 2013
·
4 revisions
We are happy to accept patches. To make the processing as simple and straightforward as possible, please consider the following:
- Send patches to
[email protected] - Follow the coding style
- Use
git format-patch - The patch set should contain test(s) for the implemented features or fixed bugs (see below)
- Each patch set should be associated with an issue describing the problem background
- Patches must be applicable to
masterbranch.
Tests should be separate patches, last elements of the patch set.
- Easy to test - no special needs, just do it (e.g. corner cases, parser errors, encoding errors, simple enhancements...).
- Difficult to test - need some non-trivial, but static input data (e.g. the storage filled with packages & bugs). Fake the data, even though it is complicated. The current testsuite provides fixtures to fill the storage with some fake data. Feel free to extend them or add others.
- Very difficult to test - need to communicate online with an external entity (Bugzilla, Open Build Service...). This is tricky, setting up such service just for testing purposes is an overkill. You can at least write a test the 'Service unavailable' case.