Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve image building approach #2

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

mathematicalmichael
Copy link
Member

@mathematicalmichael mathematicalmichael commented Apr 13, 2023

  • moved image config to build directory
  • added github action to publish an image to github packages
  • image can be pulled by binder or the user without having to build it, should speed things up

TODO:

@mathematicalmichael
Copy link
Member Author

apparently I can't use latest as a tag in my binder Dockerfile, must specify a SHA (hash) explicitly.
this makes me think that release -> triggers a commit to the same branch that updates the root Dockerfile.

For testing purposes, I'll handle this step manually for the time being as this "get github actions to add a commit" step seems potentially complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant