Push packages to attic #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aciceri
reviewed
Nov 30, 2023
aciceri
requested changes
Nov 30, 2023
There was a problem hiding this comment.
Could you please refactor this PR into a PR to hercules-ci/hercules-ci-effects?
Keep the PR a draft until I send you the function that, given a flake, returns the build closure of a flake. Otherwise perhaps I can directly add commits for it your PR if you create it from a branch on our fork.
After opening the PR there we'll use that fork as input from this repo until it gets merged.
Closed
zmrocze
force-pushed
the
zmrocze/push-to-attic
branch
2 times, most recently
from
8d7fe21 to
977e033
Compare
|
failed lint |
brainrake
force-pushed
the
zmrocze/push-to-attic
branch
10 times, most recently
from
7a89475 to
476c981
Compare
brainrake
force-pushed
the
zmrocze/push-to-attic
branch
from
2766d9c to
914cca4
Compare
aciceri
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3 fixes #34