Introduce prometheus metrics in Solr for Solr Core registry #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
April 2, 2024 13:31
richardmlu
reviewed
Apr 16, 2024
Comment on lines
+59
to
+61
| case ADMIN: | ||
| case QUERY: | ||
| case UPDATE: |
There was a problem hiding this comment.
Just curious on your thoughts about why the other cases are empty instead of removing them?
richardmlu
reviewed
Apr 16, 2024
| String prometheusMetricName, | ||
| Map<String, String> labelsMap) { | ||
| Object dropwizardMetric = (dropwizardMetricRaw).getValue(); | ||
| if (!copyOfGauges().containsKey(prometheusMetricName)) { |
There was a problem hiding this comment.
Why use copyOfGauges() in the check if it doesn't seem to be referenced again?
There was a problem hiding this comment.
Good point. Going to remove this and just reference the map. Immutable map isn't allowed upstream anyways and breaks tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT