fixing property, linting submission_runner.py

mlcommons · Mar 9, 2022 · 9bfc070 · 9bfc070
1 parent e5b5621
commit 9bfc070
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml
@@ -19,6 +19,7 @@ jobs:
       run: |
         pylint algorithmic_efficiency
         pylint baselines
+        pylint submission_runner.py
         pylint submission_runner_test.py
 
   isort:

diff --git a/algorithmic_efficiency/spec.py b/algorithmic_efficiency/spec.py
@@ -115,6 +115,7 @@ def build_input_queue(self,
   def param_shapes(self):
     """The shapes of the parameters in the workload model."""
 
+  @property
   @abc.abstractmethod
   def model_params_types(self) -> ParameterType:
     """The types of the parameters in the workload model."""
@@ -280,5 +281,5 @@ def data_selection(workload: Workload,
 
 
 def get_batch_size(workload_name):
-  """Return a per-device batch size to use for a given workload."""
+  """Return the global batch size to use for a given workload."""
   pass