Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata logging fix #544

Merged
merged 33 commits into from
Oct 16, 2023
Merged

Metadata logging fix #544

merged 33 commits into from
Oct 16, 2023

Conversation

priyakasimbeg
Copy link
Contributor

For some reason the meta data was not being written to a file.

@priyakasimbeg
set max split size
0f20678
@priyakasimbeg
tune max split size
6cf192a
@priyakasimbeg
typo
b2f8ff9
@priyakasimbeg
add back deleted block
70625b0
@priyakasimbeg
undo disable torch compile for conformer
179abba
@priyakasimbeg
remove whitespace
a2beafb
@priyakasimbeg
remove training whitespace
255d835
@priyakasimbeg
isort fix
b7f4cbc
@priyakasimbeg
formatting
bb29602
@priyakasimbeg
print step hint
3738f35
@priyakasimbeg
make pytorch cuda alloc config specific to conformer
0e4dd85
@priyakasimbeg
tune max split size
da89a8b
@priyakasimbeg
fix
416b88d
@priyakasimbeg
reduce max split size
4600d78
@priyakasimbeg
move env var
7a764e1
@priyakasimbeg
logging
1dbf3e4
@priyakasimbeg
debugging
04f5c94
@priyakasimbeg
debugging
b0b9f40
@priyakasimbeg
debug logging
318202e
@priyakasimbeg
update
3cec8c5
@priyakasimbeg
update_logging
4fc6e1c
@priyakasimbeg
fix
557bf0d
@priyakasimbeg
fix
2598d39
@priyakasimbeg
fix
9418f4f
@priyakasimbeg
remove logging
931337d
@priyakasimbeg
revert checkpoint utils debugging
aeed475
@priyakasimbeg
extend max_allowed_runtime_sec for conformer
7098843
@priyakasimbeg
Merge branch 'dev' into conformer_oom_debugging_2
cb68dba
@priyakasimbeg
Merge branch 'dev' into conformer_oom_debugging_2
24edc3b
@priyakasimbeg
remove conformer oom fixes from this branch
09ceeec
@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg priyakasimbeg changed the base branch from main to dev October 11, 2023 21:18
@priyakasimbeg priyakasimbeg marked this pull request as ready for review October 12, 2023 19:37
@priyakasimbeg priyakasimbeg requested a review from a team as a code owner October 12, 2023 19:37
@priyakasimbeg priyakasimbeg changed the title Meta data logging fix Meta-data logging fix Oct 12, 2023
@priyakasimbeg priyakasimbeg changed the title Meta-data logging fix Metadata logging fix Oct 12, 2023
@priyakasimbeg priyakasimbeg requested a review from runame October 12, 2023 19:38
runame
runame previously approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my comments, LGTM!

algorithmic_efficiency/logger_utils.py Outdated Show resolved Hide resolved
algorithmic_efficiency/logger_utils.py Outdated Show resolved Hide resolved
@priyakasimbeg priyakasimbeg merged commit 2f5774b into dev Oct 16, 2023
31 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
@priyakasimbeg priyakasimbeg deleted the meta_data_logging_fix branch November 2, 2023 22:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@runame runame runame left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@priyakasimbeg @runame