Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoring fixes #558

Merged
merged 16 commits into from
Nov 2, 2023
Merged

Scoring fixes #558

merged 16 commits into from
Nov 2, 2023

Conversation

priyakasimbeg
Copy link
Contributor

@priyakasimbeg priyakasimbeg commented Oct 30, 2023

Scoring fixes, preliminary to issues/555, issues/556 and issues/557.

@priyakasimbeg priyakasimbeg changed the base branch from main to dev October 30, 2023 20:13
@github-actions
Copy link

github-actions bot commented Oct 30, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg priyakasimbeg changed the title [WIP] Scoring fixes Scoring fixes Oct 30, 2023
@priyakasimbeg priyakasimbeg marked this pull request as ready for review October 31, 2023 21:47
@priyakasimbeg priyakasimbeg requested a review from a team as a code owner October 31, 2023 21:47
runame
runame previously approved these changes Nov 2, 2023
Copy link
Contributor

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my question, LGTM.

scoring/scoring.py Outdated Show resolved Hide resolved
@priyakasimbeg priyakasimbeg merged commit 8736a30 into dev Nov 2, 2023
31 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
@priyakasimbeg priyakasimbeg deleted the scoring_fixes branch November 2, 2023 22:23
Copy link
Contributor

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment.

@@ -37,6 +37,7 @@ install_requires =
absl-py==1.4.0
numpy>=1.23
pandas>=2.0.1
tabulate==0.9.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it used anywhere else in the repo? Couldn't find anything with a quick search.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants