Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OGBG workload variants #605

Merged
merged 55 commits into from
Jan 11, 2024
Merged

OGBG workload variants #605

merged 55 commits into from
Jan 11, 2024

Conversation

priyakasimbeg
Copy link
Contributor

@priyakasimbeg priyakasimbeg commented Jan 4, 2024

Add OGBG workload variants:

  • SiLU : replace RELU activation functions with SiLU activation functions.
  • GELU: replace RELU activation functions with GELU activation functions. Note we explicitly set PyTorch GELU approximate arg to tanh to match the JAX GELU default implementation.
  • Model Size:
    • Change num_ message_passing_steps from 5 to 3
    • Add dense layer in update functions by changing hidden_dims for update functions from (256) to (256, 256)
    • Reduce latent_dim from 256 to 128

Add modeldiff test for OGBG. The original test was broken w a KeyError. I rewrote the key_transform for translating PyTorch layer names to JAX layer names so that it generalizes across OGBG variants.

Fixed formulas for calculating input dimensions in update functions in PyTorch OGBG model.

Copy link

github-actions bot commented Jan 4, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg priyakasimbeg changed the base branch from main to dev January 4, 2024 17:52
@priyakasimbeg priyakasimbeg marked this pull request as ready for review January 4, 2024 17:53
@priyakasimbeg priyakasimbeg requested a review from a team as a code owner January 4, 2024 17:53
@priyakasimbeg priyakasimbeg requested a review from runame January 4, 2024 17:53
Copy link
Contributor

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@priyakasimbeg priyakasimbeg merged commit 9b063d7 into dev Jan 11, 2024
31 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
@priyakasimbeg priyakasimbeg deleted the ogbg_workload_variants branch February 10, 2024 01:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants