Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev -> main #695

Merged
merged 62 commits into from
Mar 11, 2024
Merged
Changes from 1 commit
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
0e59088
update dockerfile
priyakasimbeg Feb 28, 2024
335acbc
update readme
priyakasimbeg Feb 28, 2024
d01c101
fix jax installation for CUDA12
priyakasimbeg Feb 29, 2024
e981883
jax changes
priyakasimbeg Feb 29, 2024
47056f0
install secondary packages after frameworks
priyakasimbeg Mar 1, 2024
75aea9a
pin networkx package
priyakasimbeg Mar 2, 2024
3527781
Add flag for num_workers for workloads with PyTorch data loaders
runame Mar 6, 2024
fd54806
Fix formatting
runame Mar 6, 2024
86ae524
More formatting
runame Mar 6, 2024
3f6eb42
move jax core deps installation order
priyakasimbeg Mar 6, 2024
a2fffd8
update deadline on readme
priyakasimbeg Mar 6, 2024
ceaad98
update readme with lik for key dates
priyakasimbeg Mar 6, 2024
1ddbd36
fix jaxlib version
priyakasimbeg Mar 7, 2024
2761c9f
Only allow setting num_workers for eval
runame Mar 7, 2024
6147007
Fix flag description
runame Mar 7, 2024
389fe3f
add measurement.csv files for prize_qualification_baselines
priyakasimbeg Mar 7, 2024
79f3c51
ignore csv files
priyakasimbeg Mar 7, 2024
d511aff
gitignore
priyakasimbeg Mar 7, 2024
42e9c8f
gitignore
priyakasimbeg Mar 7, 2024
c58eb66
Merge pull request #689 from mlcommons/prize_qualificaton_logs
priyakasimbeg Mar 7, 2024
cf1e85e
Merge branch 'dev' into cuda121
priyakasimbeg Mar 7, 2024
0d6df49
clean up setup.cfg
priyakasimbeg Mar 7, 2024
3ae3010
update readme
priyakasimbeg Mar 7, 2024
3014413
update singularity.def
priyakasimbeg Mar 7, 2024
40a665b
Merge pull request #659 from mlcommons/cuda121
priyakasimbeg Mar 7, 2024
fcdd645
update criteo eval bsz for pytorch and jax
priyakasimbeg Mar 7, 2024
6d3a6b0
Merge pull request #687 from runame/fix-num-workers
priyakasimbeg Mar 7, 2024
76e3aee
clarify bsz is tunable for training but not evals
priyakasimbeg Mar 7, 2024
47bd8e0
imagenet data setup fix
priyakasimbeg Mar 7, 2024
5f2dfbf
add options to skip download for imagenet and fastmri
priyakasimbeg Mar 7, 2024
c16490e
data setup improvements
priyakasimbeg Mar 7, 2024
6d69b46
Merge pull request #690 from mlcommons/criteo_eval_bsz
priyakasimbeg Mar 8, 2024
79e7881
fix
priyakasimbeg Mar 8, 2024
b452e88
debugging
priyakasimbeg Mar 8, 2024
735fa27
debug
priyakasimbeg Mar 8, 2024
4a2f61e
debugging
priyakasimbeg Mar 8, 2024
035a88d
clarification in readme
priyakasimbeg Mar 8, 2024
0c36551
formatting
priyakasimbeg Mar 8, 2024
e4fd21c
remove debugging blocks
priyakasimbeg Mar 8, 2024
44da785
Merge branch 'dev' into imagenet_data_fix
priyakasimbeg Mar 8, 2024
d1a6a0c
undo scoring changes
priyakasimbeg Mar 8, 2024
96e0c02
undo workloads.py changes
priyakasimbeg Mar 8, 2024
ff4819e
Merge pull request #691 from mlcommons/readme_updates
priyakasimbeg Mar 8, 2024
4944038
formatting
priyakasimbeg Mar 8, 2024
1f4e010
Merge pull request #692 from mlcommons/imagenet_data_fix
priyakasimbeg Mar 8, 2024
803644a
add documentation to scoring updates
priyakasimbeg Mar 9, 2024
7d86575
fix performance profile calculations
priyakasimbeg Mar 9, 2024
2847824
scoring fixes
priyakasimbeg Mar 9, 2024
9220cee
add test data back in
priyakasimbeg Mar 9, 2024
cc4538b
formatting
priyakasimbeg Mar 9, 2024
34e4b1b
import order fixes
priyakasimbeg Mar 9, 2024
2700fc3
add todos
priyakasimbeg Mar 9, 2024
3a88afd
remove print statements
priyakasimbeg Mar 9, 2024
0b00a5c
fix
priyakasimbeg Mar 9, 2024
e9084ad
refactor
priyakasimbeg Mar 9, 2024
842b055
formatting
priyakasimbeg Mar 9, 2024
2b41c79
Merge pull request #694 from mlcommons/scoring_fix
priyakasimbeg Mar 9, 2024
02c7730
Fix check for eval_num_workers attribute
runame Mar 10, 2024
1f7c727
Fix pylint
runame Mar 10, 2024
bd87497
Actually fix pylint
runame Mar 10, 2024
08db4d5
Fix the fix
runame Mar 10, 2024
c54062c
Merge pull request #696 from runame/fix-num-workers
priyakasimbeg Mar 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add todos
priyakasimbeg committed Mar 9, 2024

Verified

This commit was signed with the committer’s verified signature.
gastaldi George Gastaldi
commit 2700fc36cbde583f2dac6dc3bdf2f04ad28781d1
7 changes: 3 additions & 4 deletions scoring/test_performance_profile.py
Original file line number Diff line number Diff line change
@@ -5,20 +5,19 @@
from scoring import performance_profile
from scoring import scoring_utils

TEST_LOGFILE = 'test_data/adamw_fastmri_jax_04-18-2023-13-10-58.log'
TEST_DIR = 'test_data/experiment_dir'
NUM_EVALS = 18


class Test(absltest.TestCase):

def test_get_workloads_time_to_target(self):
# TODO(kasimbeg)
pass

def test_get_best_trial_index(self):
# TODO(kasimbeg)
pass

def test_compute_performance_profiles(self):
# TODO(kasimbeg)
pass